Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cleanup #2237

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Build cleanup #2237

merged 2 commits into from
Jan 9, 2025

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Jan 9, 2025

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

Fixes some warnings that got reported in an attempt at #2226.

@rr- rr- added Internal The invisible stuff TR2 TR1 labels Jan 9, 2025
@rr- rr- self-assigned this Jan 9, 2025
@rr- rr- requested review from a team as code owners January 9, 2025 09:52
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team January 9, 2025 09:52
@lahm86
Copy link
Collaborator

lahm86 commented Jan 9, 2025

There is a (new) warning here for both win builds

https://github.com/LostArtefacts/TRX/actions/runs/12687501994/job/35362040584?pr=2237#step:5:266

@rr- rr- merged commit 185fd2e into develop Jan 9, 2025
8 checks passed
@rr- rr- deleted the build-cleanup branch January 9, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal The invisible stuff TR1 TR2
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants