-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tr2/lara/cheat: reset gun status if undrawing weapons #2380
tr2/lara/cheat: reset gun status if undrawing weapons #2380
Conversation
This fixes guns potentially appearing in Lara's hand while entering the fly cheat and the weapon undraw animation is still running. Resolves LostArtefacts#2376.
Download the built assets for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks – LGTM and it solves the original issue.
I noticed one more thing, but I don't think we need to solve it as it's really minor – if you time the fly cheat just right, the holsters sound is played twice:
2025-01-25_15-06-02.mp4
I think we could resolve all of these fly cheat/gun issues by enforcing Lara out of the draw/undraw animations, but it would be quite jarring. At least for the most part she will complete putting the gun away neatly. This one looks quite tricky, maybe we'd have to be more thorough in our checks and look at frame numbers. |
I don't think it's worth it at the moment – we can raise an issue for this so that it doesn't get lost, but I'd say it's super low priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked all the rifles and everything looks good. I also made sure to check the harpoon while Lara is in water for good measure.
Thank you for working on fixing this issue. 👍
Resolves #2376.
Checklist
Description
This fixes guns potentially appearing in Lara's hand while entering the fly cheat and the weapon undraw animation is still running.