-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game flow rework (pt 6) #2381
Merged
Merged
Game flow rework (pt 6) #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
January 25, 2025 14:02
lahm86
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As an aside, perhaps we should add a guard when starting a demo to verify that the level actually has demo data; currently it crashes if it's missing, but that's the same on develop.
I'll address this and #2383 here. |
@lahm86 done |
lahm86
approved these changes
Jan 25, 2025
(Just rebasing on top of newest develop.) |
aredfan
approved these changes
Jan 25, 2025
walkawayy
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This one is significantly smaller – I only move the demos in TR1 to their own key, removing the
"demo"
boolean property from individual levels. This now matches TR2 and I'd like to follow-up with cutscenes and the title level, and eventually the Gym (which likely will prove to be the hardest, as it's put before regular levels.)The TR1 GF level reader is refactored to have a similar structure to TR2.