This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
virtual_file: add function to set position #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahm86
requested review from
rr- and
walkawayy
and removed request for
a team
rr-
reviewed
Sep 9, 2024
src/virtual_file.c
Outdated
| @@ -53,6 +53,14 @@ size_t VFile_GetPos(const VFILE *file) | |||
| return file->cur_ptr - file->content; | |||
| } | |||
|
|
|||
| void VFile_SetPos(VFILE *file, const size_t pos) | |||
src/virtual_file.c
Outdated
| const size_t cur_pos = VFile_GetPos(file); | ||
| const int32_t offset = pos - cur_pos; | ||
| assert(cur_pos + offset <= file->size); | ||
| file->cur_ptr += offset; |
There was a problem hiding this comment.
Maybe we could just go with file->cur_ptr = file->content + pos, and add an assertion that pos >= 0?
There was a problem hiding this comment.
Fixed, thanks. Left the assert doing an upper check as size_t is unsigned (produces a warning adding it).
lahm86
force-pushed
the
add-vfile-setpos
branch
from
bb732b4 to
2c3309e
Compare
walkawayy
approved these changes
Sep 9, 2024
rr-
approved these changes
Sep 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a seek function for convenience, but I went with a similar name to
GetPos.