Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Import /hp and /pos console commands to libtrx #29

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Import /hp and /pos console commands to libtrx #29

merged 6 commits into from
Sep 18, 2024

Conversation

rr-
Copy link
Contributor

@rr- rr- commented Sep 17, 2024

No description provided.

@rr- rr- self-assigned this Sep 17, 2024
@rr- rr- requested a review from a team as a code owner September 17, 2024 23:55
@rr- rr- requested review from lahm86 and walkawayy and removed request for a team September 17, 2024 23:55
@@ -0,0 +1,3 @@
GS_DEFINE(OSD_POS_GET, "Room: %d\nPosition: %.3f, %.3f, %.3f\nRotation: %.3f,%.3f,%.3f")
GS_DEFINE(OSD_CURRENT_HEALTH_GET, "Current Lara's health: %d")
GS_DEFINE(OSD_CURRENT_HEALTH_SET, "Lara's health set to %d")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require language translations to now translate this second file on top of the strings in the gameflow? Unless I'm reading wrong this early lol. That would be my only feedback.

Copy link
Contributor Author

@rr- rr- Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. These provide reasonable defaults in case the player or level builder removes the strings from the gameflow. Our tools automatically backpropagate these as default overrides to the gameflow files to highlight what can be overridden, but they are not strictly necessary as they ship the same strings that we provide here in the executable itself.

For a developer this means updating it only in this single place for libtrx strings, and in relevant .def files for TR1X and TR2X specific strings. The rest should be taken care of by tools/update_gameflow.

@rr- rr- merged commit b95beda into main Sep 18, 2024
2 checks passed
@rr- rr- deleted the libtrx-console branch September 18, 2024 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants