qt5+: Switch from QRegExp to QRegularExpression
#301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`QRegularExpression` was introduced in Qt 5.0 as a successor to `QRegExp`, and while it is still supported under Qt 6 (via `Core5Compat`), the corresponding `QRegExpValidator` is not. Hence, migrating will be required before being able to port to Qt 6 (LubosD#297). While `QRegularExpression` is not always a drop-in replacement for `QRegExp` (see the documentation¹ for details), in our case, it is. Our use doesn't run into any of the situations listed in the documentation, while our only instance of `exactMatch()` uses a pattern that is already anchored. ¹ https://doc.qt.io/qt-5/qregularexpression.html#notes-for-qregexp-users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QRegularExpressionwas introduced in Qt 5.0 as a successor toQRegExp, and while it is still supported under Qt 6 (viaCore5Compat), the correspondingQRegExpValidatoris not. Hence,migrating will be required before being able to port to Qt 6 (#297).
While
QRegularExpressionis not always a drop-in replacement forQRegExp(see the documentation¹ for details), in our case, it is. Ouruse doesn't run into any of the situations listed in the documentation,
while our only instance of
exactMatch()uses a pattern that is alreadyanchored.
¹ https://doc.qt.io/qt-5/qregularexpression.html#notes-for-qregexp-users