Slightly improve feedback given when hitting hold notes #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supposed to reduce allocs in non-gameplay/editor scenarios.
It's universal anyways, might as well enforce it there.
I think it fits in better personally
…forms is disabled
SlideBody stars are now consistent with every other timed DHO.
Neat visually, but felt bad in gameplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #668
When hitting the hold notes, the note now continuously flashes to indicate they are being held.
Also improved the transform code across all the HitObject to (hopefully) increase their reliability in replay/editor scenarios.
Screencast.From.2025-02-27.21-58-43.mp4
Screencast.From.2025-02-27.21-59-18.mp4