Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Commit

Permalink
chore: add deprecation notice
Browse files Browse the repository at this point in the history
  • Loading branch information
avik-pal committed Jul 24, 2024
1 parent adf12f6 commit 9764707
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "LuxAMDGPU"
uuid = "83120cb1-ca15-4f04-bf3b-6967d2e6b60b"
authors = ["Avik Pal <[email protected]> and contributors"]
version = "0.2.3"
version = "0.2.4"

[deps]
AMDGPU = "21141c5a-9bdb-4563-92ae-f87d6854732e"
Expand Down
14 changes: 14 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,20 @@
[![ColPrac: Contributor's Guide on Collaborative Practices for Community Packages](https://img.shields.io/badge/ColPrac-Contributor's%20Guide-blueviolet)](https://github.com/SciML/ColPrac)
[![SciML Code Style](https://img.shields.io/static/v1?label=code%20style&message=SciML&color=9558b2&labelColor=389826)](https://github.com/SciML/SciMLStyle)

> [!CAUTION]
>
> `LuxAMDPU.jl` was used previously as a means to load `AMDGPU` specific extensions in
`Lux.jl`. However in most recent versions of `Lux.jl`, these functionalities can be
directly accessed by simply loading `AMDGPU.jl`. This package is now deprecated.
>
> To use the `LuxAMDGPU.functional()` functionality, use `MLDataDevices.functional(LuxAMDGPUDevice)`.
>
> If you are not using `LuxAMDGPU.jl` as a direct dependency, please consider
opening an issue on any packages you are using that do use it as a dependency.
From Julia 1.9 onwards, you can query `]why LuxAMDGPU` to figure out which
package originally brings it in as a dependency.


`LuxAMDGPU` is meant to be used as a trigger package for all AMDGPU dependencies in `Lux`.
Users requiring AMDGPU support should install `LuxAMDGPU` and load it alongside `Lux`.

Expand Down
18 changes: 18 additions & 0 deletions src/LuxAMDGPU.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
module LuxAMDGPU

if ccall(:jl_generating_output, Cint, ()) == 1
@warn """
DEPRECATION NOTICE
`LuxAMDPU.jl` was used previously as a means to load `AMDGPU` specific extensions in
`Lux.jl`. However in most recent versions of `Lux.jl`, these functionalities can be
directly accessed by simply loading `AMDGPU.jl`. This package is now deprecated.
To use the `LuxAMDGPU.functional()` functionality, use
`MLDataDevices.functional(LuxAMDGPUDevice)`.
If you are not using `LuxAMDGPU.jl` as a direct dependency, please consider
opening an issue on any packages you are using that do use it as a dependency.
From Julia 1.9 onwards, you can query `]why LuxAMDGPU` to figure out which
package originally brings it in as a dependency.
"""
end

using Reexport

@reexport using AMDGPU, AMDGPU.ROCKernels
Expand Down

2 comments on commit 9764707

@avik-pal
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/111647

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.2.4 -m "<description of version>" 9764707227f5d2e063e5035aa58a0fa2a7021c41
git push origin v0.2.4

Please sign in to comment.