-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/simplesdxl-package] Add SimpleSDXL as package #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot CLA Assistant bot All Contributors have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA |
mohnjiles
reviewed
Oct 25, 2024
mohnjiles
approved these changes
Oct 26, 2024
Looks good, thank you! will probably merge once @ionite34 reviews and get this into the next release. |
ionite34
approved these changes
Oct 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Discord: https://canary.discord.com/channels/1115555685476868168/1297228642870493234/1297228642870493234
(I'm
nullping
on Discord)I want to add SimpleSDXL as a package which is a fork of Fooocus just like RuinedFooocus. It adds support for Flux, Pony, has a better architecture, more presets, etc.
There were a lot of hiccups down the road because that package does not have the best dependency management, but I managed to fix all the issues now.