Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to resolve Issue 16 #37

Merged
merged 6 commits into from
Nov 22, 2024
Merged

to resolve Issue 16 #37

merged 6 commits into from
Nov 22, 2024

Conversation

roman2git
Copy link
Contributor

@roman2git roman2git commented Nov 8, 2024

What?

To close issue #16

Have you done?

  • Code tests
  • Update documentation
  • Update changelog

Details to be checked: (optional)

There are minor changes which were highlighted by linter/IDE:

  • Added class fields to rule/Rule
  • fixed field in docstring

Linked issues: (optional)

@roman2git roman2git mentioned this pull request Nov 8, 2024
Copy link
Collaborator

@develop-cs develop-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍
Few comments following the Conventional Comments format.

Copy link
Collaborator

@develop-cs develop-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 Thank you

@develop-cs develop-cs merged commit c0dcda9 into MAIF:main Nov 22, 2024
4 checks passed
@roman2git roman2git deleted the issue-16 branch February 21, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Pydantic V2 models
2 participants