Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mda theme #307

Merged
merged 13 commits into from
Sep 5, 2023
Merged

Switch to mda theme #307

merged 13 commits into from
Sep 5, 2023

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented Sep 4, 2023

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilyminium
Copy link
Member Author

No you're right, thanks!

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small questions, otherwise lgtm!

import MDAnalysis as mda
import msmb_theme
import sphinx_rtd_theme
import subprocess
from ipywidgets.embed import DEFAULT_EMBED_REQUIREJS_URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst we're here, are we using this anywhere anymore?

html_logo = "_static/logos/user_guide.png"

html_context = {"versions_json_url": "https://userguide.mdanalysis.org/versions.json"}

# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".
html_static_path = ["_static"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have stuff in _static (thinking of the above user_guide.png, should we keep this around?

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @lilyminium !

@@ -14,13 +14,8 @@
# import sys

import datetime
import subprocess
from collections import OrderedDict

import MDAnalysis as mda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some pre-commit failure with import orders and an extra blank line on 124 if that matters to you.

@IAlibay
Copy link
Member

IAlibay commented Sep 5, 2023

That is a looonnnng RTD build (probably that specific runner but let's keep an eye out for this).

@IAlibay IAlibay merged commit 4e72848 into develop Sep 5, 2023
@IAlibay IAlibay deleted the switch-docs-theme branch September 5, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants