-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to mda theme #307
Switch to mda theme #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No you're right, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small questions, otherwise lgtm!
doc/source/conf.py
Outdated
import MDAnalysis as mda | ||
import msmb_theme | ||
import sphinx_rtd_theme | ||
import subprocess | ||
from ipywidgets.embed import DEFAULT_EMBED_REQUIREJS_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst we're here, are we using this anywhere anymore?
html_logo = "_static/logos/user_guide.png" | ||
|
||
html_context = {"versions_json_url": "https://userguide.mdanalysis.org/versions.json"} | ||
|
||
# Add any paths that contain custom static files (such as style sheets) here, | ||
# relative to this directory. They are copied after the builtin static files, | ||
# so a file named "default.css" will overwrite the builtin "default.css". | ||
html_static_path = ["_static"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have stuff in _static
(thinking of the above user_guide.png
, should we keep this around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @lilyminium !
doc/source/conf.py
Outdated
@@ -14,13 +14,8 @@ | |||
# import sys | |||
|
|||
import datetime | |||
import subprocess | |||
from collections import OrderedDict | |||
|
|||
import MDAnalysis as mda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some pre-commit failure with import orders and an extra blank line on 124 if that matters to you.
That is a looonnnng RTD build (probably that specific runner but let's keep an eye out for this). |
MDAnalysis/mdanalysis-sphinx-theme#33
📚 Documentation preview 📚: https://mdanalysis--307.org.readthedocs.build/en/307/