Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grand Update PackNameConverter.cs #39

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

TheMrKochan
Copy link

Updated the names of the packs and added new translations. @sgkoishi I hope you won't be too offended if I use your translations and the work in General as a basis. Please don't swear, this is my first time trying to make edits :)

Updated the names of the packs and added new translations.
@TheMrKochan
Copy link
Author

@MGK82 I think it's time to update this part of the extension on a large scale, don't you think? Would be consistency to write to you on email, if you don't mind.

@sgkoishi
Copy link
Contributor

Well technically those belong to Blizzard but they should be open to the community :)
Just wondering, did you grab the names of Book of Heroes and Year of the Dragon manually? I didn't see those translations in the dbf resource

@TheMrKochan
Copy link
Author

@sgkoishi something manually through the translator, something from the official site, only changing the region (this is about the year of the Dragon). Regarding the book of heroes, Yes, everything is manual. I have no experience in programming and a complete zero in this, but I decided to help with what I could :)

@TheMrKochan
Copy link
Author

I thought it would be easier to identify the pack than " Standard pack class name". Oh, you've made additional changes, I'll have to "steal" your code again. Damn...

@sgkoishi
Copy link
Contributor

I thought it would be easier to identify the pack than " Standard pack class name". Oh, you've made additional changes, I'll have to "steal" your code again. Damn...

I extract the translations from the game itself. For those "Standard" packs they were actually unnamed in the game data, finding it through the store page takes much more time so I just use their description instead.

@TheMrKochan
Copy link
Author

If not a secret: how do you do this? I want to try it, hehe

@sgkoishi
Copy link
Contributor

If not a secret: how do you do this? I want to try it, hehe

Not quite sure if that should be a secret but it probably violates EULA: Google for some tools and targets the file called dbf.unity3d (inside Hearthstone directory).

@TheMrKochan TheMrKochan changed the title Update PackNameConverter.cs Grand Update PackNameConverter.cs Dec 14, 2020
Updated the name of the Rogue in simplified Chinese.
Updated translation and added Thai language wherever possible.
@TheMrKochan
Copy link
Author

Updated for new expansion

@TheMrKochan
Copy link
Author

Hello @MGK82 ! When do you plan to update the extension?

@Volkai7
Copy link

Volkai7 commented Mar 30, 2021

Found some more pack ID-name connections, is this the right place to put them?

Pack ID : Set
643 -- GOLDEN Madness at the Darkmoon Faire pack
"Golden Pack" -- Hunter Class pack
545 -- Mage Class pack
498 -- Year of the Dragon pack

@Volkai7
Copy link

Volkai7 commented Mar 31, 2021

MORE Pack IDs:
Forged in the Barrens -- 553
GOLDEN Forged in the Barrens -- 686
Year of the Phoenix -- 688
Paladin Class -- 632
Warrior Class -- 633
Priest Class -- 634
Rogue Class -- 635

@TheMrKochan
Copy link
Author

@Volkai7 Hi, these positions are already in the file, it remains to wait for the author of the extension and he will update it.

@Volkai7
Copy link

Volkai7 commented Mar 31, 2021

Oh! ALso 603 is GOLDEN Scholomance Academy

@Volkai7
Copy link

Volkai7 commented Mar 31, 2021

@Volkai7 Hi, these positions are already in the file, it remains to wait for the author of the extension and he will update it.

Glad to hear it! I didn't know where to look so I just started finding the packs in history that had an ID and identifying what they were.

@TheMrKochan
Copy link
Author

Glad to hear it! I didn't know where to look so I just started finding the packs in history that had an ID and identifying what they were.

check my profile, may be find some interesting

@TheMrKochan
Copy link
Author

Here is all available pack names at current time

@sgkoishi
Copy link
Contributor

sgkoishi commented Apr 7, 2021

I've updated some pack names in my repo.

  • Rename Year of the ___ to Year of the ___ Card Pack
  • Use official translations for class packs (Mage Card Pack, Paladin Card Pack, etc.)
    (no druid or warlock yet, but everything else is 100% same as in-game)

@TheMrKochan
Copy link
Author

I've updated some pack names in my repo.

  • Rename Year of the ___ to Year of the ___ Card Pack
  • Use official translations for class packs (Mage Card Pack, Paladin Card Pack, etc.)
    (no druid or warlock yet, but everything else is 100% same as in-game)

Hi! Please tell me what are the advantages or differences from the main build?

@sgkoishi
Copy link
Contributor

sgkoishi commented Apr 7, 2021

I've updated some pack names in my repo.

  • Rename Year of the ___ to Year of the ___ Card Pack
  • Use official translations for class packs (Mage Card Pack, Paladin Card Pack, etc.)
    (no druid or warlock yet, but everything else is 100% same as in-game)

Hi! Please tell me what are the advantages or differences from the main build?

Comparing to your version: all year-or-the-something and all class packs translations from in-game reward list
https://gist.github.com/sgkoishi/d276fe3e770b9078504bcb03c3eb11e5/revisions

I'm not sure if you machine translate some names or not, but at least for zhTW and zhCN, you version is like Pack Hunter and mine is Hunter Card Pack

@TheMrKochan
Copy link
Author

I'm not sure if you machine translate some names or not, but at least for zhTW and zhCN, you version is like Pack Hunter and mine is Hunter Card Pack

I would like to switch to your build, but I do not yet understand what exactly you have changed compared to the original extension from MGK82

@sgkoishi
Copy link
Contributor

sgkoishi commented Apr 7, 2021

I'm not sure if you machine translate some names or not, but at least for zhTW and zhCN, you version is like Pack Hunter and mine is Hunter Card Pack

I would like to switch to your build, but I do not yet understand what exactly you have changed compared to the original extension from MGK82

If you mean by the codebase:

  <ItemGroup>
    <EmbeddedResource Include="Resources\packs.json" />
  </ItemGroup>

@TheMrKochan
Copy link
Author

@sgkoishi I translate some program items manually into Russian, in your version I will be able to do this without the same problems as it is happening now?

@sgkoishi
Copy link
Contributor

sgkoishi commented Apr 7, 2021

@sgkoishi I translate some program items manually into Russian, in your version I will be able to do this without the same problems as it is happening now?

I'm not sure what problem it is - but those new texts I'm using are extracted from the game (REWARD_LIST) and should match each other

@TheMrKochan
Copy link
Author

I mean the xaml files in the Controls directory

@sgkoishi
Copy link
Contributor

sgkoishi commented Apr 7, 2021

I mean the xaml files in the Controls directory

Still not sure what the problem is. Do you need help translating the GUI of this plugin?

@TheMrKochan
Copy link
Author

I mean the xaml files in the Controls directory

Still not sure what the problem is. Do you need help translating the GUI of this plugin?

No, thank you, I have already figured out and translated only for myself the main points of the interface)

@TheMrKochan
Copy link
Author

I mean the xaml files in the Controls directory

Still not sure what the problem is. Do you need help translating the GUI of this plugin?

Promise that you will not abandon the updates of this extension, you will support it and PERHAPS add some nice features (for example, manually adding the contents of packages. I've seen this somewhere in forks) and I'm all yours :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants