-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grand Update PackNameConverter.cs #39
base: master
Are you sure you want to change the base?
Conversation
Updated the names of the packs and added new translations.
@MGK82 I think it's time to update this part of the extension on a large scale, don't you think? Would be consistency to write to you on email, if you don't mind. |
Well technically those belong to Blizzard but they should be open to the community :) |
@sgkoishi something manually through the translator, something from the official site, only changing the region (this is about the year of the Dragon). Regarding the book of heroes, Yes, everything is manual. I have no experience in programming and a complete zero in this, but I decided to help with what I could :) |
I thought it would be easier to identify the pack than " Standard pack class name". Oh, you've made additional changes, I'll have to "steal" your code again. Damn... |
I extract the translations from the game itself. For those "Standard" packs they were actually unnamed in the game data, finding it through the store page takes much more time so I just use their description instead. |
If not a secret: how do you do this? I want to try it, hehe |
Not quite sure if that should be a secret but it probably violates EULA: Google for some tools and targets the file called |
Updated the name of the Rogue in simplified Chinese.
Little fix
Updated translation and added Thai language wherever possible.
Updated for new expansion |
Hello @MGK82 ! When do you plan to update the extension? |
Some fix
Found some more pack ID-name connections, is this the right place to put them? Pack ID : Set |
MORE Pack IDs: |
@Volkai7 Hi, these positions are already in the file, it remains to wait for the author of the extension and he will update it. |
Oh! ALso 603 is GOLDEN Scholomance Academy |
Glad to hear it! I didn't know where to look so I just started finding the packs in history that had an ID and identifying what they were. |
check my profile, may be find some interesting |
Here is all available pack names at current time |
I've updated some pack names in my repo.
|
Hi! Please tell me what are the advantages or differences from the main build? |
Comparing to your version: all year-or-the-something and all class packs translations from in-game reward list I'm not sure if you machine translate some names or not, but at least for zhTW and zhCN, you version is like |
I would like to switch to your build, but I do not yet understand what exactly you have changed compared to the original extension from MGK82 |
If you mean by the codebase:
|
@sgkoishi I translate some program items manually into Russian, in your version I will be able to do this without the same problems as it is happening now? |
I'm not sure what problem it is - but those new texts I'm using are extracted from the game (REWARD_LIST) and should match each other |
I mean the xaml files in the Controls directory |
Still not sure what the problem is. Do you need help translating the GUI of this plugin? |
No, thank you, I have already figured out and translated only for myself the main points of the interface) |
Promise that you will not abandon the updates of this extension, you will support it and PERHAPS add some nice features (for example, manually adding the contents of packages. I've seen this somewhere in forks) and I'm all yours :D |
Updated the names of the packs and added new translations. @sgkoishi I hope you won't be too offended if I use your translations and the work in General as a basis. Please don't swear, this is my first time trying to make edits :)