new: [support for signing] added #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added new class CryptographicKeys - added functions to to_feed calls to include crypto keys - added protected boolean field to misp event - updated feed generator to support signing - if the new setting is set to True signing will be attempted for protected events - protected events are now passed to the /cryptographic_keys/serverSign endpoint of misp for signing - signatures are included as a .asc file in the output directory - TODO: - currently the JSON dumping is moved from a streamed dumping to an in memory dump before saving to disk - add a check for protected events and revert to streamed dumping for non protected events - alternatively use the already saved files to request signing from MISP
Rafiot
reviewed
Dec 9, 2024
| @@ -1559,7 +1559,8 @@ def __repr__(self) -> str: | |||
| class MISPEvent(AnalystDataBehaviorMixin): | |||
|
|
|||
| _fields_for_feed: set[str] = {'uuid', 'info', 'threat_level_id', 'analysis', 'timestamp', | |||
| 'publish_timestamp', 'published', 'date', 'extends_uuid'} | |||
| 'publish_timestamp', 'published', 'date', 'extends_uuid', | |||
| 'protected'} | |||
There was a problem hiding this comment.
Just a note: we need to add in def _set_default an entry self.protected = False, to keep consistency with the other required fields.
I'm assuming protected set to false par default is the expected value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new class CryptographicKeys
added functions to to_feed calls to include crypto keys
added protected boolean field to misp event
updated feed generator to support signing
TODO: