This repository has been archived by the owner on Dec 29, 2023. It is now read-only.
Changed from ; to && #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
&& only continues if the previous command went successfully, as ; does not care, which can create potential problems
|
@Kortho This one can cause problems. The reason we actually changed from && to ; is because some commands while executing cleanly do not return 0 (or sometimes even return). Every once in a while this can bite you. Normally, completely agree that you want to reply on "X, Y, Z" happening consecutively, but there are too many moving parts here, and we have seen "non clean" (vs error) codes multiple times show up as randomly as they disappear. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&& continues the run if the previous command executed correctly, where ; does not and can cause problems