Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] refactor the github login #216

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[MRG] refactor the github login #216

merged 1 commit into from
Sep 20, 2024

Conversation

leeeizhang
Copy link
Collaborator

Before submitting this PR, please make sure you have:

  • confirmed all checks still pass OR confirm CI build passes.
  • verified that any code or assets from external sources are properly credited in comments and/or in
    the credit file.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 20, 2024
@leeeizhang leeeizhang changed the title [WIP] refactor the github login [MRG] refactor the github login Sep 20, 2024
@dosubot dosubot bot added the enhancement New feature or request label Sep 20, 2024
huangyz0918
huangyz0918 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@huangyz0918 huangyz0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 20, 2024
@huangyz0918 huangyz0918 merged commit c802a3c into MLSysOps:main Sep 20, 2024
4 checks passed
@leeeizhang leeeizhang deleted the lei/refactor-login branch September 21, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangyz0918 huangyz0918 huangyz0918 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leeeizhang @huangyz0918