Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] add limited line argument into read_file function #257

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[MRG] add limited line argument into read_file function #257

merged 1 commit into from
Oct 25, 2024

Conversation

leeeizhang
Copy link
Collaborator

Closes #254

Before submitting this PR, please make sure you have:

  • confirmed all checks still pass OR confirm CI build passes.
  • verified that any code or assets from external sources are properly credited in comments and/or in
    the credit file.

@leeeizhang leeeizhang self-assigned this Oct 25, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 25, 2024
@leeeizhang leeeizhang changed the title [WIP] add limited line argument into function [WIP] add limited line argument into read_file function Oct 25, 2024
@dosubot dosubot bot added the enhancement New feature or request label Oct 25, 2024
@leeeizhang leeeizhang changed the title [WIP] add limited line argument into read_file function [MRG] add limited line argument into read_file function Oct 25, 2024
huangyz0918
huangyz0918 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@huangyz0918 huangyz0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 25, 2024
@huangyz0918 huangyz0918 merged commit 2a87550 into MLSysOps:main Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangyz0918 huangyz0918 huangyz0918 approved these changes

Assignees

@leeeizhang leeeizhang

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add limitation to the read_file function
2 participants
@leeeizhang @huangyz0918