-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sfr): kinematic wave approximation option #1899
Merged
jdhughes-usgs
merged 16 commits into
MODFLOW-ORG:develop
from
jdhughes-usgs:sfr-kinematic-6.6.0.dev0
Sep 26, 2024
Merged
feat(sfr): kinematic wave approximation option #1899
jdhughes-usgs
merged 16 commits into
MODFLOW-ORG:develop
from
jdhughes-usgs:sfr-kinematic-6.6.0.dev0
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82896dd
to
e5775cc
Compare
5903ce9
to
d525ca8
Compare
5afafcf
to
79ac096
Compare
79ac096
to
6d97936
Compare
6d97936
to
4b62044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to consider. The method looks like it is working as expected, especially based on our offline discussion of the Mahoning Creek example.
langevin-usgs
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist of items for pull request
black
on new and modified autotestsfprettify
For additional information see instructions for contributing and instructions for developing.