Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documented get right matrix in cross correlation #226

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

edinvay
Copy link
Contributor

@edinvay edinvay commented Nov 3, 2023

I documented a method of a class that I am not responsible for documenting, but I really wanted it to be properly described. Moreover, there were added some reminders which methods are to be documented later by me.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8def0a) 66.37% compared to head (58fa3e1) 66.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   66.37%   66.37%           
=======================================
  Files         169      169           
  Lines        9832     9833    +1     
=======================================
+ Hits         6526     6527    +1     
  Misses       3306     3306           
Files Coverage Δ
src/core/CrossCorrelationCache.cpp 76.47% <ø> (ø)
src/core/InterpolatingBasis.cpp 100.00% <ø> (ø)
src/core/LegendreBasis.cpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edinvay edinvay marked this pull request as ready for review November 3, 2023 15:00
@ilfreddy ilfreddy merged commit 492ca39 into MRChemSoft:master Nov 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants