Mrpt graphslam improvements #824
Conversation
Used this script: https://github.com/marcusmueller/include-guard-convert Got it right 9/10 times
Current commit also includes:
- Move of default/initial values from the constructors to the member
variables themselves in the header file.
|
Awesome, thanks for not forgetting! ;-) Just curious: why do you prefer explicitly defining dtors as It seems we (again) have the Docker auth problem within Travis for this PR... Will test the code manually (tomorrow?) and merge then. |
|
Probably just for readability? |
|
Thanks @Logrus ! Indeed, that justifies using default instead of an empty body. But then my next question is: wouldn't it be more compact and totally equivalent just NOT defining any ctor/dtor at all if all data members are trivial? It would make the code a little shorter... ;-) |
|
|
||
| MRPT_START; | ||
| MRPT_LOG_DEBUG_STREAM("In initializeSlamMetricVisualization..."); | ||
| ASSERTDEB_(m_visualize_SLAM_metric); | ||
|
|
||
| // initialize the m_win_plot on the stack | ||
| m_win_plot = new CDisplayWindowPlots( | ||
| "Evolution of SLAM metric - Deformation Energy (1:1000)", 400, 300); | ||
| m_win_plot.reset(new mrpt::gui::CDisplayWindowPlots( |
There was a problem hiding this comment.
I'd prefer std::make_shared<mrpt::gui::CDisplayWindowPlots>("Evolution of SLAM metric - Deformation Energy (1:1000)", 400, 300));
There was a problem hiding this comment.
I of course meant std::make_unique
I slightly prefer |
bergercookie
force-pushed
the
mrpt-graphslam-improvements
branch
from
9bf3999
to
f39ecf3
Compare
Changed apps/libraries
PR Description
PR includes a parital cleanup of the mrpt_graphslam library. This mostly includes the newer C++11 syntax and constructs (see #697)
I acknowledge to have:
CONTRIBUTINGpagedoc/doxygen-pages/changeLog_doc.hto describe these changes (if applicable)AUTHORS(if applicable)(Notify: @MRPT/owners )