Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventionnement de l'outre-mer #1419

Merged
merged 15 commits into from
May 22, 2024
Merged

Conventionnement de l'outre-mer #1419

merged 15 commits into from
May 22, 2024

Conversation

syldb
Copy link
Contributor

@syldb syldb commented May 10, 2024

@syldb syldb force-pushed the outre-mer branch 3 times, most recently from 5d37276 to 6d15236 Compare May 15, 2024 06:11
Copy link

github-actions bot commented May 15, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7908 6495 82% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/forms/convention_form_financement.py 84% 🟢
conventions/models/convention.py 89% 🟢
conventions/services/convention_generator.py 79% 🟢
programmes/models/choices.py 96% 🟢
programmes/models/models.py 97% 🟢
programmes/signals.py 100% 🟢
TOTAL 91% 🟢

updated for commit: f0c6b9e by action🐍

@syldb syldb marked this pull request as ready for review May 15, 2024 12:13
@syldb syldb requested a review from a team as a code owner May 15, 2024 12:13
@syldb syldb requested review from kolok and etchegom and removed request for a team May 15, 2024 12:13
@@ -193,6 +194,10 @@ def generate_convention_doc(convention: Convention, save_data=False) -> DocxTemp
context.update(adresse)

doc.render(context, _get_jinja_env())
if convention.is_outre_mer:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syldb : je suis prenaur d'une démo ici, je ne sais pas bien ce qui ce passe :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca vient de la doc de python docx Removing a header

An unwanted header can be removed by assigning True to its .is_linked_to_previous attribute

J'ai simplifié pour accéder le header principal directement, ça retire une ligne de code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je peux te faire une démo de la génération, ça nécessite de créer en local une opération située en outre-mer

programmes/models/models.py Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syldb syldb merged commit 4904b40 into main May 22, 2024
8 checks passed
@syldb syldb deleted the outre-mer branch May 22, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants