Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to update code_insee_departement in admin #1747

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

syldb
Copy link
Contributor

@syldb syldb commented Feb 13, 2025

Lien Mattermost : https://mattermost.incubateur.net/fabnum-mte/pl/sfjdadke8if13nxgm9mf4ty1iy

Ajout dans l'admin de cette valeur au cas où on update un code postal, il faut penser à la changer si le département bouge

N'oublier pas de taguer : bug, enhancement, documentation, technical, dependencies (+ escalation, regression si besion)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

@syldb syldb requested a review from a team as a code owner February 13, 2025 14:43
@syldb syldb requested review from kolok and etchegom and removed request for a team February 13, 2025 14:43
@syldb syldb force-pushed the admin-programme-code-insee branch from c45c171 to e929c99 Compare February 13, 2025 14:43
Copy link

github-actions bot commented Feb 13, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8576 7087 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
programmes/admin.py 85% 🟢
TOTAL 85% 🟢

updated for commit: e929c99 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants