Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Niveau de complexité remis à 10 #1749

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

etchegom
Copy link
Contributor

@etchegom etchegom commented Feb 14, 2025

Description succincte du problème résolu

Niveau de complexité (max-complexity) remis à la valeur 10.
Et pour cela:

  • j'ai ignoré certaines parties de code, ça vaut pas le coup de les refactoriser IMO (ex: ecoloweb, ou scripts de dedup)
  • j'ai splitté certaines méthodes trop longues, où on atteignait un niveau légèrement supérieur à 10

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

Deux parties à tester manuellement, car pas de tests unitaires:

  • new_avenant
  • validate_convention

@etchegom etchegom self-assigned this Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8583 7092 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/services/recapitulatif.py 70% 🟢
conventions/services/search.py 96% 🟢
conventions/views/avenants.py 55% 🟢
TOTAL 73% 🟢

updated for commit: 4ecdfe7 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant