-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Compare impacts by subimpacts and run the comparison during export #38
base: main
Are you sure you want to change the base?
Conversation
da587a2
to
b1c97ca
Compare
…ata into refactor_comparison
How can I check with simapro unavailable ? |
You connect to the simapro machine and stop the API then relaunch an export.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use functions when we can to avoid code duplication. And what about adding an option to generate the graphs or to disable their generation?
…ata into refactor_comparison
Good idea, I've added an option to an internal function, and exported this option to the output process. So now the plot are generated when running for instance |
🔧 Problem
The current comparison graphs don't display useful informations, the impacts seem the same across all sub-impacts
![image](https://private-user-images.githubusercontent.com/283404/409945361-4dfa0b44-8c0f-4884-8a91-5199fdcab478.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODAwOTMsIm5iZiI6MTczOTU3OTc5MywicGF0aCI6Ii8yODM0MDQvNDA5OTQ1MzYxLTRkZmEwYjQ0LThjMGYtNDg4NC04YTkxLTUxOTlmZGNhYjQ3OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwMDM2MzNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOTdhZjg5ZjRhNjQ5NzFmN2Q2NDEwZmRkZTcwYjQwNDY1ZDg2YjhmNTM0MWFkZWMwNDdiZTczZWY5MzQ2NmU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.h7g11dK6W6Cr4O5jK66oRiyWtt5-LRe_y6mpCKiDJQk)
The comparison is a separate command and is not always launched during export. It is not included in the npm commands and may end up being abandonned.
🍰 Solution
🏝️ How to test
Run the export (make export / npm run export:all) and check there are comparison graphs.
Check that the export still run if simapro is not available.