chore(data): Add irrigation to the Ecoinvent organic cotton #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccomb
changed the title
|
Maurine doesn't validate the change |
|
The change is not about the difference between conventional and organic cotton, it's just about adding irrigation to the organic cotton. |
|
Tested locally, |
vjousse
approved these changes
Nov 21, 2024
vjousse
pushed a commit
that referenced
this pull request
Dec 5, 2024
## [2.7.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.6.0..v2.7.0) (2024-12-04) ### 🚀 Features - *(objects)* Introduce components for objects and veli ([#825](#825)) - *(textile)* Update number of references index thresholds. ([#839](#839)) - Introduce objects/veli components db and explorer ([#841](#841)) ### 🚜 Refactor - Move weaving elec_pppm to textile wellknown. ([#843](#843)) ### ⚙️ Miscellaneous Tasks - *(data)* New ingredients ([#814](#814)) - *(data)* Add irrigation to the Ecoinvent organic cotton ([#832](#832)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
The organic cotton is a EI-modified one with only irrigation added. It's impacts are hardcoded and not retrieved from either simapro or brightway.
🍰 Solution
Use the Ecoinvent organic cotton and add a strategy to add irrigation to it during import.
🚨 Points to watch/comments
This may only applies on brightway, as I'm unsure where to find the modified organic cotton in SimaPro. It would be great to first merge #822
🏝️ How to test
Run the
make clean_data import_ecoinventthen check in brightway / EI 3.9.1 and EI 3.10 that the organic cotton has an irrigation in the technosphere.Compare the new impact with the previous ones.
ecobalyse-data: organic_cotton