Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(textile,ui): apply default trims on product category change #910

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

n1k0
Copy link
Member

@n1k0 n1k0 commented Jan 27, 2025

See Notion card which exhaustively describes the use case and expectations.

@n1k0 n1k0 requested a review from vjousse January 27, 2025 10:48
@n1k0 n1k0 changed the title Feat/apply product default trims feat(textile): apply product default trims Jan 27, 2025
@n1k0 n1k0 changed the title feat(textile): apply product default trims feat(textile,ui): apply default trims on product category change Jan 27, 2025
@n1k0 n1k0 force-pushed the feat/apply-product-default-trims branch from 0276e60 to 5db4aa0 Compare January 27, 2025 10:57
@n1k0 n1k0 force-pushed the feat/apply-product-default-trims branch from 5db4aa0 to a296472 Compare January 27, 2025 12:49
Copy link
Collaborator

@vjousse vjousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally works as expected. I tested bookmarked products not having the trim property by tweaking the local storage and it works fine too (doesn't display any trim) 👍

@n1k0 n1k0 merged commit aa4c3fb into master Jan 27, 2025
6 checks passed
@n1k0 n1k0 deleted the feat/apply-product-default-trims branch January 27, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants