Merge pull request #3642 from MTES-MCT/feature/3641-blacklist-ci

[CI] Blacklist les fonctions de debug

assets/scripts/vanilla/services/form_helper.js

@@ -1,3 +1,5 @@
+import * as Sentry from "@sentry/browser";
+
 Node.prototype.addEventListeners = function (eventNames, eventFunction) {
   for (const eventName of eventNames.split(' ')) { this.addEventListener(eventName, eventFunction) }
 }
@@ -97,8 +99,6 @@ forms.forEach((form) => {
           const finishSubmitBtn = document.querySelector('#form_finish_submit')
           request.open('POST', event.target.getAttribute('data-handle-url'))
           request.upload.addEventListener('progress', function (e) {
-            console.log('progress')
-            console.log(e)
             totalProgress.classList.remove('fr-hidden')
             finishSubmitBtn.disabled = true
             finishSubmitBtn.innerHTML = 'Téléversement en cours, veuillez patienter....'
@@ -112,8 +112,6 @@ forms.forEach((form) => {
             progress.value = percentCompleted
           })
           request.addEventListener('load', function (e) {
-            console.log('load')
-            console.log(e)
             event.target.parentElement.classList.remove('fr-icon-refresh-line');
             [preview, deleter].forEach(el => el?.classList?.remove('fr-hidden'))
             progress.value = 0
@@ -124,6 +122,8 @@ forms.forEach((form) => {
               resTextEl.innerText = jsonRes.error
               resTextEl.classList.remove('fr-hidden')
               resTextEl.classList.add('fr-text-label--red-marianne')
+              console.error(jsonRes.error)
+              Sentry.captureException(new Error(error))
             } else {
               resTextEl.innerText = jsonRes.titre
               resTextEl.classList.remove('fr-hidden')

assets/scripts/vanilla/services/search_filter_form.js

@@ -30,7 +30,6 @@ const removeBadge = (badge) => {
   select.querySelector(`option[value="${val}"]`)?.classList?.remove('fr-hidden')
   input?.remove()
   const badges = badge.parentElement.querySelectorAll('.fr-badge[data-value]').length !== 1
-  console.log(badge.parentElement.querySelectorAll('.fr-badge[data-value]').length)
   if (!badges) {
     badge?.parentElement?.querySelector('.fr-badge:not([data-value])')?.classList?.remove('fr-hidden')
     if (select.tagName === 'SELECT') { select.options[0].selected = true }

composer.json

@@ -74,9 +74,11 @@
     "require-dev": {
         "dama/doctrine-test-bundle": "8.2.*",
         "doctrine/doctrine-fixtures-bundle": "^3.4",
+        "ekino/phpstan-banned-code": "^2.1",
         "fakerphp/faker": "^1.20",
         "nelmio/api-doc-bundle": "^4.32",
         "phpro/grumphp-shim": "^1.13",
+        "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "1.10.44",
         "phpunit/phpunit": "^9.5",
         "symfony/browser-kit": "7.1.*",
@@ -90,10 +92,11 @@
     "config": {
         "allow-plugins": {
             "composer/package-versions-deprecated": true,
-            "symfony/flex": true,
-            "symfony/runtime": true,
+            "php-http/discovery": true,
             "phpro/grumphp-shim": true,
-            "php-http/discovery": true
+            "phpstan/extension-installer": true,
+            "symfony/flex": true,
+            "symfony/runtime": true
         },
         "optimize-autoloader": true,
         "classmap-authoritative": true,

eslint.config.mjs

@@ -18,6 +18,7 @@ export default [
             "no-unused-expressions": "off",
             "vue/no-mutating-props": "off",
             "vue/no-reserved-component-names": "off",
+            "no-console": ["error", { "allow": ["warn", "error"] }]
         },
     },
-]
+]

grumphp.yml

@@ -4,14 +4,6 @@ grumphp:
         enforce_capitalized_subject: false
         matchers:
            must contain github issue number: '/#(\d+)$/'
-      git_blacklist:
-        keywords:
-          - 'var_dump('
-          - 'dump('
-          - ' dd('
-          - ';dd('
-          - 'die('
-          - 'exit('
       yamllint:
         parse_custom_tags: true
       phpstan: ~