Seed more realistic housing adresses and coordinates #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicguillois
approved these changes
Nov 26, 2024
Falinor
force-pushed
the
test-seed-realistic-housings
branch
from
4c214c1 to
28e54a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address is supposed to be much better than a random one. It should be correct in most cases.
Also, it is guaranteed to be in the establishment’s perimeter, provided that the perimeter is correct, of course.
Limitations
The coordinates are still generated randomly. It could create issues in the test data, for instance when generated in the middle of a lake, a forest... But it’s test data, after all.