-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework housing precisions modal #1118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8b2083
to
07e11b9
Compare
6fe52c0
to
5205e7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based upon the one which settled foundations to update the housing edition modal.
This branch should add the precision modal, its three tabs, retrieving and saving precisions for a housing.
The old fields (
precisions
,vacancy_reasons
) and the new join table (housing_precisions
) should both be written at the same time. Reads will still come from the old fields and get translated in the front app, using the referential of precisions coming from the database.Features
housing_precisions
PrecisionTabs
PrecisionModalNext
to wrapPrecisionTabs
(shall replacePrecisionModal
later)Refactoring
ConfirmationModal
The confirmation modal was based on @codegouvfr/react-dsfr’s Modal but included the opening button and the modal, which lacks flexibility for some use cases. Thus
ConfirmationModalNext.tsx
and its functioncreateConfirmationModal
has been added to only provide a basic modal with default buttons : cancel and save.Previous branch updates
AsideNext
based on MUI’s Drawer to replace our customAside
AppSelectNext
to replace our oldAppSelect
hasRole
middlewaretransaction
module to start a transaction throughout several repositories