HW 2 - Jibran Khan #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…understanding how to do the assignment, but wanted to get something uploaded online so there's something there for now. will update soon!
rossbernet
requested changes
Feb 10, 2019
| @@ -61,7 +80,10 @@ and if it is not, it prints to the console, "TRY WITH STRINGS" | |||
| ===================== */ | |||
|
|
|||
|
|
|||
| var trump = function() {}; | |||
| var trump = function isString(input) { | |||
| if String.isString(input); {return input.capitalize}; | |||
There was a problem hiding this comment.
I know you said you're not done, but I am just looking through now anyhow. Happy to chat in office hours! but wanted to start the review.
There was a problem hiding this comment.
(capitalize as far as I know it not a thing in javascript)
| @@ -62,11 +62,30 @@ | |||
|
|
|||
| ===================== */ | |||
|
|
|||
| var jsonToCsv = function(json) { console.log(json); }; | |||
| var jsonToCsv = function(json) { | |||
There was a problem hiding this comment.
This output of this task is "csv-style" array of arrays that turns:
[{'first': 1, 'second': 44}, {'first': 2, 'second': 12}]
into
[['first','second'],[1, 44],[2, 12]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed assignment for HW #2 and solved most of lab 1. The parts of lab 1 and lab 2 that were not solved here, I would like to review in OH. I will attempt lab 2 part 2 (the bike stations) in Week 3 pull request as the lab is replicated there.
Thanks!