HW4 - Mayu Tanaka #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonoyuan
reviewed
Feb 11, 2019
| /* ===================== | ||
| Fill out this function definition | ||
| ===================== */ | ||
| $.ajax(phillySolarInstallationDataUrl).done(function(data){ myData = JSON.parse(data); }); |
There was a problem hiding this comment.
can you access myData outside of the ajax wrapper? this doesn't seem to work when I do it
There was a problem hiding this comment.
I had to redefine phillySolarInstallationDataUrl in this file, but I was able to access myData as a global variable.
rossbernet
approved these changes
Feb 17, 2019
| var plotMarkers = function() {}; | ||
| var downloadData = $.ajax("http://raw.githubusercontent.com/CPLN692-MUSA611/datasets/master/json/philadelphia-bike-crashes-snippet.json"); | ||
| var parseData = function(url) { return JSON.parse(url); }; | ||
| var makeMarkers = function(json) { |
There was a problem hiding this comment.
var makeMarkers = function(json) {
// var markers = [];
markerArr = _.map(json, function(feature) {
return L.marker([feature.lat_final, feature.long_final]);
});
return markerArr;Small improvement suggestion: using _.map instead of _.each, which creates the array and doesn't require the push
| _.each(myData, function(feature) { | ||
| var marker = L.marker([feature.LAT, feature.LONG_]).bindPopup(feature.NAME); | ||
| if (booleanField && feature.YEARBUILT>2010) { | ||
| marker = marker.setOpacity(0.25); |
There was a problem hiding this comment.
This opacity is a nice effect for the query results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.