Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW4 - Ian Schwarzenberg #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IanSchwarzenberg
Copy link

No description provided.

Copy link
Member

@rossbernet rossbernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are quite close.

And you have great comments.

But I had an error trying to get the points to load for the final part. Let me know if I just missed something.

@@ -103,12 +109,27 @@ var phillyBikeCrashesDataUrl = "https://raw.githubusercontent.com/CPLN692-MUSA61
Remember to call all code within the function body. Use console.log to make sure
that this step is completed before moving on!
===================== */

var parsedData = JSON.parse(testing);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have defined this function parseData inside another function (the ajax call)

So when you try to call it on line 112, it can't find it.

image


//};

var makeMarkers = function(obj) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting the following error when I try to plot points:

image

It could be that I need to adjust the filtering. But are you able to visualize points? Do I need to change the filter parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants