HW4-Zixuan Xu #2
Conversation
| }; | ||
| var makeMarkers = function(parseData) { | ||
| var markers = []; | ||
| _.forEach(parseData, function(x){ |
There was a problem hiding this comment.
Small improvement suggestion: using _.map instead of _.each, which creates the array and doesn't require the push
| /* ===================== | ||
| Define a resetMap function to remove markers from the map and clear the array of markers | ||
| ===================== */ | ||
| var resetMap = function() { | ||
| var resetMap = function(myMarkers) { |
There was a problem hiding this comment.
I can't get your resetMap() to work.
I think it's because myMarkers has undefined elements in, as per this screen shot:
I'm not exactly sure why you have undefineds in there because your conditional logic looks good to filter those out. But alas, it has undefined.
| _.forEach(myData, function(x){ | ||
| var marker; | ||
| if (booleanField && x["UCR Code"] == 600) { | ||
| marker = L.marker([x.Lat, x.Lng]).bindPopup(x["General Crime Category"]).addTo(map); |
There was a problem hiding this comment.
I hadn't requested clarifying comments before this HW was due... but for next time, it'd be helpful to have some comments to help understand what it is you are trying to filter here by so I could get a good idea from the outset without needing to understand all the logic.
But it looks good.
No description provided.