-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
동기부여 tableViewCell을 만들었습니다 #143
Conversation
SceneDelegate
public override func viewDidLoad() { | ||
super.viewDidLoad() | ||
|
||
self.title = "Home" | ||
self.view.backgroundColor = .systemBackground |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 attribute에 빼는게 좋지 않을까요?
|
||
enum HomeCell { | ||
case banner | ||
} | ||
|
||
public class HomeViewController: UIViewController, Stepper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseViewController는 아직 사용 안하신 건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빨리 수정하겠습니다!
enum으로 뺸 이유는 추후에 유지보수를 위해서 입니다!
import RxCocoa | ||
import RxSwift | ||
import Core | ||
import DSKit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 그리고 이거 코드 스타일 맞춰야해요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵!
개선 사항