Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

동기부여 tableViewCell을 만들었습니다 #143

Closed
wants to merge 9 commits into from

Conversation

jjunhaa0211
Copy link
Member

@jjunhaa0211 jjunhaa0211 commented Jan 26, 2024

개선 사항

  • 유동적으로 늘어나지 않는 tableViewCell
  • color 추가
    Simulator Screenshot - iPhone 15 Pro Max M - 2024-01-26 at 16 22 54

@jjunhaa0211 jjunhaa0211 added kind/기능 이런 기능을 지금 추가할려고 합니다. kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다. 고치지 않음 이 작업은 수행하지 않을 것입니다. labels Jan 26, 2024
public override func viewDidLoad() {
super.viewDidLoad()

self.title = "Home"
self.view.backgroundColor = .systemBackground
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 attribute에 빼는게 좋지 않을까요?


enum HomeCell {
case banner
}

public class HomeViewController: UIViewController, Stepper {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseViewController는 아직 사용 안하신 건가요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빨리 수정하겠습니다!

enum으로 뺸 이유는 추후에 유지보수를 위해서 입니다!

import RxCocoa
import RxSwift
import Core
import DSKit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 그리고 이거 코드 스타일 맞춰야해요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다. kind/기능 이런 기능을 지금 추가할려고 합니다. 고치지 않음 이 작업은 수행하지 않을 것입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants