Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

홈 뷰 구현 #149

Merged
merged 29 commits into from
Jan 29, 2024
Merged

홈 뷰 구현 #149

merged 29 commits into from
Jan 29, 2024

Conversation

jjunhaa0211
Copy link
Member

@jjunhaa0211 jjunhaa0211 commented Jan 29, 2024

  • 걸음 가져오는 뷰
  • 오늘 루틴 가져오는 뷰
  • 와카타이머 뷰
  • 칼로리 계산 뷰

완료 했습니다

  • 현재 문제점은 아직 viewModel 세팅을 못한 것과 유동적으로 커져야하는 동기부여 페이지 입니다

@jjunhaa0211 jjunhaa0211 self-assigned this Jan 29, 2024
@jjunhaa0211 jjunhaa0211 added 고치지 않음 이 작업은 수행하지 않을 것입니다. kind/기능 이런 기능을 지금 추가할려고 합니다. kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다. labels Jan 29, 2024

public override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) {
super.init(style: style, reuseIdentifier: reuseIdentifier)

attribute()
addViews()
layout()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout() 코드 빼는 이유가 무엇인가요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout 코드는 init 보다는 layoutSubviews 에서 view가 실행되기 전에 미리 실행시켜야할 것 같아서 이렇게 했습니다

required public init?(coder aDecoder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}
func configure(with message: MotivationMessageModel) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 함수 public 이어야 하지 않나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

솔직히 저 class가 public이라서 상관없을 것 같은데 보기 안좋으니까 수정하겠습니다

@Eunho0922 Eunho0922 merged commit 03a7939 into develop Jan 29, 2024
1 check passed
@Eunho0922 Eunho0922 deleted the feature/#148-makeHomeView branch January 29, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다. kind/기능 이런 기능을 지금 추가할려고 합니다. 고치지 않음 이 작업은 수행하지 않을 것입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants