Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: [#155] ์ž๊ธฐ๊ด€๋ฆฌ - ๋‚ด ๋ฃจํ‹ด - ๋ฃจํ‹ด ์ˆ˜์ • #156

Merged
merged 27 commits into from
Feb 1, 2024

Conversation

Eunho0922
Copy link
Member

  • View ๊ตฌํ˜„ ํ–ˆ์–ด์š”
  • ๊ธฐ๋Šฅ ๊ตฌํ˜„์€ ๋ฆฌํŽ™ํ† ๋ง ํ•˜๋ฉด์„œ ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

Eunho0922 and others added 19 commits January 31, 2024 16:34
ํŒŒ์ผ , ํƒ€์ž… ์ถ”๊ฐ€
ํƒ€์ž… ์ถ”๊ฐ€
์ธ๋ฑ์Šค ์—๋Ÿฌ ๊ณ ์นจ
@Eunho0922 Eunho0922 self-assigned this Feb 1, 2024
@Eunho0922 Eunho0922 requested a review from jjunhaa0211 February 1, 2024 06:09
@Eunho0922 Eunho0922 added the kind/๊ธฐ๋Šฅ ์ด๋Ÿฐ ๊ธฐ๋Šฅ์„ ์ง€๊ธˆ ์ถ”๊ฐ€ํ• ๋ ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค. label Feb 1, 2024
@Eunho0922
Copy link
Member Author

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-01.at.15.07.58.mp4

@Eunho0922
Copy link
Member Author

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-01.at.17.08.15.mp4

@@ -11,7 +11,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {

guard let windowScene = (scene as? UIWindowScene) else { return }
window = UIWindow(windowScene: windowScene)
window?.rootViewController = UINavigationController(rootViewController: SelfCareMyRoutineDetailViewController(SelfCareMyRoutineDetailViewModel()))
window?.rootViewController = UINavigationController(rootViewController: SelfCareMyRoutineEditViewController(SelfCareMyRoutineEditViewModel()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๊ฑฐ lint ์—๋Ÿฌ ๋‚  ๊ฒƒ ๊ฐ™์•„์š” core์— ๋งŒ๋“ค์–ด ๋†“์€๊ฑฐ ์‚ฌ์šฉ ๋˜๋Š” ์–ธ๋”๋ฐ” ํ•œ๋ฒˆ ํ•ด์ฃผ์„ธ์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต

$0.register(MyRoutineEditTableViewCell.self,
forCellReuseIdentifier: MyRoutineEditTableViewCell.identifier)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ ์ด๋ ‡๊ฒŒ ๋งŽ์ด ๋„์šฐ๋ฉด ์•ˆ๋ผ์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต

import Core

public class SelfCareMyRoutineEditViewModel: BaseViewModel {
public func transform(_ input: Input) -> Output {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ ์ œ๊ฐ€ ๋ฐ”๊พผ๊ฑฐ ์žˆ๋Š”๋ฐ ๋‹ด ๋ถ€ํ„ฐ๋Š” ๊ทธ๊ฑธ๋กœ ํ•ด์ฃผ์„ธ์š” (๋‚˜์ค‘์— ๋ฆฌํŽ™)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต

}
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ ‡๊ฒŒ ๋งŽ์ด ๋„์šฐ๋ฉด ์•ˆ๋˜์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค

@jjunhaa0211 jjunhaa0211 merged commit cacee8c into develop Feb 1, 2024
1 check passed
@jjunhaa0211 jjunhaa0211 deleted the feature/#155-myRoutineEditView branch February 1, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/๊ธฐ๋Šฅ ์ด๋Ÿฐ ๊ธฐ๋Šฅ์„ ์ง€๊ธˆ ์ถ”๊ฐ€ํ• ๋ ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants