Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Preparing 추가 #354

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Empty Preparing 추가 #354

merged 4 commits into from
Jun 26, 2024

Conversation

jjunhaa0211
Copy link
Member

@jjunhaa0211 jjunhaa0211 commented Jun 26, 2024

What kind of this PR?

Preparing 추가


What is this PR? 🔍

Screenshot 📸

기존 코드
스크린샷 2024-06-26 오후 3 45 09

변경된 코드
스크린샷 2024-06-26 오후 3 45 36


Changes 🗒️

  • PreparingViewController 추가
  • MGPreparingType 추가

Describe your changes 💉

  • ShopViewController의 코드 간소화를 진행했습니다.
  • PicklePreparingViewController의 코드 간소화를 진행

PR Checklist ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • 커밋 메시지 컨벤션에 맞게 작성했습니다. Commit message convention 참고 (Ctrl + 클릭하세요.)
  • 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).
  • Lint에 맞게 개발하셨나요?
  • 한명이상의 리뷰가 달렸나요?

@jjunhaa0211 jjunhaa0211 requested a review from Eunho0922 as a code owner June 26, 2024 06:44
@jjunhaa0211 jjunhaa0211 self-assigned this Jun 26, 2024
@jjunhaa0211 jjunhaa0211 requested a review from cyj513 June 26, 2024 06:44
@jjunhaa0211 jjunhaa0211 added the kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다. label Jun 26, 2024
@Eunho0922 Eunho0922 merged commit bc77432 into develop Jun 26, 2024
1 check passed
@jjunhaa0211 jjunhaa0211 deleted the refactoring/#353-emptyView branch June 26, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants