Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Evening compliments are shown during the day #3727

Open
2 of 4 tasks
rejas opened this issue Feb 26, 2025 · 0 comments
Open
2 of 4 tasks

[Bug] Evening compliments are shown during the day #3727

rejas opened this issue Feb 26, 2025 · 0 comments

Comments

@rejas
Copy link
Collaborator

rejas commented Feb 26, 2025

Environment

SYSTEM: manufacturer: Apple Inc.; model: MacBookPro18,3; virtual: false

OS: platform: darwin; distro: macOS; release: 15.3.1; arch: arm64; kernel: 24.3.0

VERSIONS: electron: 32.3.0; used node: 22.11.0; installed node: 22.11.0; npm: 10.9.0; pm2: 5.4.3

OTHER: timeZone: Europe/Berlin; ELECTRON_ENABLE_GPU: undefined

Which start option are you using?

npm run start

Are you using PM2?

No

Module

compliments

Have you tried disabling other modules?

  • Yes
  • No

Have you searched if someone else has already reported the issue on the forum or in the issues?

  • Yes

What did you do?

Happens when the compliments array of the morning/day times is not set at all instead of being an empty array.

What did you expect to happen?

no compliments being shown

What actually happened?

evening events are shown since the code falls into them as a fallback

Additional comments

No response

Participation

  • I am willing to submit a pull request for this change.
@rejas rejas added the bug label Feb 26, 2025
@rejas rejas self-assigned this Feb 26, 2025
khassel pushed a commit that referenced this issue Feb 27, 2025
Fixes #3727

---------

Co-authored-by: veeck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants