Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty part-of-day logic #3726

Merged
merged 8 commits into from
Feb 27, 2025
Merged

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Feb 24, 2025

Fixes #3727

@rejas rejas marked this pull request as draft February 24, 2025 13:06
@sdetweil
Copy link
Collaborator

where is the code change? i see tests but no change to compliments.js

@rejas
Copy link
Collaborator Author

rejas commented Feb 24, 2025

Just a draft because its still work in progress. I want to create some tests first

@rejas rejas closed this Feb 26, 2025
@rejas rejas reopened this Feb 26, 2025
@rejas rejas marked this pull request as ready for review February 26, 2025 10:51
@rejas
Copy link
Collaborator Author

rejas commented Feb 26, 2025

now its ready @sdetweil

Copy link
Collaborator

@sdetweil sdetweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let timeOfDay = "";

will be true later, an empty string is not same as null
IMG_0795

if (timeOfDay &&

@rejas rejas requested a review from sdetweil February 27, 2025 12:00
@khassel khassel merged commit 4a398f0 into MagicMirrorOrg:develop Feb 27, 2025
11 checks passed
@rejas rejas deleted the issue/compliments branch February 27, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants