Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @eslint/js dependency. Already installed with eslint in deep #3636

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

bugsounet
Copy link
Contributor

@bugsounet bugsounet commented Nov 17, 2024

I lint my modules and just see this:

@eslint/js is now not needed.
it's installed by eslint it self

@rejas rejas merged commit bd1324c into MagicMirrorOrg:develop Nov 17, 2024
10 checks passed
@bugsounet bugsounet deleted the eslint branch November 17, 2024 13:34
@bugsounet
Copy link
Contributor Author

pinging: @KristjanESPERANTO do you see this ?

@KristjanESPERANTO
Copy link
Contributor

We've had this issue at some point before. I usually prefer to have dependencies that we import in the package.json. But in this case we will probably never run into a real problem, so I think the change is okay 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants