Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not currently working on galaxy a5 2017 #16

Open
stoicpenguin2234 opened this issue Jan 31, 2024 · 0 comments
Open

Not currently working on galaxy a5 2017 #16

stoicpenguin2234 opened this issue Jan 31, 2024 · 0 comments

Comments

@stoicpenguin2234
Copy link

I tried installing this module on my galaxy a5 2017 running lineageos 18.1 and the latest version of magisk but I kept getting the error ( error occurred while mounting system
FAB1150 added a commit to FAB1150/IPControl-fork that referenced this issue Feb 9, 2024
@FAB1150
modify the way update-binary mounts /system
6872d6e 
I'm extremely new to magisk modules (in fact, this is the first time Iook into one), so excuse the ignorance.

This PR should solve issue Magisk-Modules-Repo#16 as it mounts /system as it does in https://github.com/nathanchance/magisk-modules/blob/master/META-INF/com/google/android/update-binary .

This removes the systemless check (and mounts /data twice), but it works if installed from the magisk app module manager. Probably needs some modification before merging
@FAB1150 FAB1150 mentioned this issue Feb 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stoicpenguin2234