modify the way update-binary mounts /system #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm extremely new to magisk modules (in fact, this is the first time Iook into one), so excuse the ignorance. This PR should solve issue Magisk-Modules-Repo#16 as it mounts /system as it does in https://github.com/nathanchance/magisk-modules/blob/master/META-INF/com/google/android/update-binary . This removes the systemless check (and mounts /data twice), but it works if installed from the magisk app module manager. Probably needs some modification before merging
it indeed could be modified before merging. It now mounts /system in rw if $SYSTEMLESS is false like before, and doesn't mount a bunch of unneeded stuff. This should also solve issue Magisk-Modules-Repo#11, looking into it.
|
It indeed could be modified before merging. It now mounts /system in rw if $SYSTEMLESS is false like before, and doesn't mount a bunch of unneeded stuff. This should also solve issue #11, looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm extremely new to magisk modules (in fact, this is the first time Iook into one), so excuse the ignorance.
This PR should solve issue #16 as it mounts /system as it does in https://github.com/nathanchance/magisk-modules/blob/master/META-INF/com/google/android/update-binary .
This removes the systemless check (and mounts /data twice), but it works if installed from the magisk app module manager. Probably needs some modification before merging