-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install problem and Chrome Certificate Transparency problem #16
Open
andyacer
wants to merge
9
commits into
Magisk-Modules-Repo:master
Choose a base branch
from
andyacer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented solution is described below. Directly copied from the Adguard issue explanation. Recommended way to use this module:
|
@ianmacd I don't use Magisk anymore. Please review. |
This fix works for me. Certificates are now both in the user and system store, which makes Chrome happy when applying the Denylist. |
URARUA
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the previous install fix from azio7 and also addresses the Certificate Transparency problem with Chrome. The method of addressing the CT problem is described in these issues:
movecert issue
Adguard issue
The method of this "fix" is to change the primary operation of this module from "moving" to "copying." The certificate is copied to the system store, with the original left in the user store. With the certificate in both places, and if the Zygist DenyList is used against Chrome, the all objectives are achieved. Chrome will use the certificate from the user store, where CT is not enforced by default, and all other apps will use the certificate from the System store, where it's often trusted by default.