[flutter_appauth] remove idTokenHint assert #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am wondering if there is a specific reason for this assert? Currently we want to only supply our postLogoutRedirectUrl but not the idTokenHint in our app. We tried using the additionalParameters field to supply only the postLogoutRedirectUrl, but that causes fatal exception in android. Would be nice to remove this assert, unless there is a reason with OpenID why we'd want to enforce it like this. Let me know! Thank you!
|
Hi @clintpurser, it's been a while so I don't remember the exact reasoning. I believe the goal was encouraging developers to providing all details or nothing at all. Typically both are given as giving both is indicates the app is providing details on who should be logged out and where the IdP should go to upon a successful logout. These are assertions though so shouldn't be impacting release builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MaikuB
I am wondering if there is a specific reason for this assert?
Currently we want to only supply our postLogoutRedirectUrl but not the idTokenHint for logging out in our app. We tried using the additionalParameters field to supply only the post_logout_redirect_uri, but that causes fatal exception in android.
Would be nice to remove this assert, unless there is a reason with OpenID why we'd want to enforce it like this.
Let me know!
Thank you!