Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unsafe_set!(::Textbox, ::String) #4417

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bjarthur
Copy link
Contributor

@bjarthur bjarthur commented Sep 27, 2024

Description

a return value of nothing is clearly wrong for this do-block as the lifted observable is a Tuple of Points.
i came across this error when manually setting displayed_string in an app of mine. happy to add a test if someone suggests how to do so.

EDIT: a 2nd commit now adds an unexported unsafe_set!, which like the extant set! method sets the displayed_string but does not throw an exception if the string does not pass the validator function. the use case is to highlight the portion of the string that does not pass the validator by replacing it with the invalid portion. was the most simple UI for an app of mine.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Added unit tests for new algorithms, conversion methods, etc.
  • Added an entry in CHANGELOG.md (for new features and breaking changes)

@bjarthur bjarthur force-pushed the bja/fixtextbox branch 2 times, most recently from 5c6d019 to e30ba7b Compare October 3, 2024 14:23
@bjarthur bjarthur changed the title correct errant return value in textbox logic add unsafe_set!(::Textbox... Oct 3, 2024
@bjarthur
Copy link
Contributor Author

bjarthur commented Oct 3, 2024

ready for review!

@bjarthur bjarthur changed the title add unsafe_set!(::Textbox... add unsafe_set!(::Textbox, ::String) Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

1 participant