add unsafe_set!(::Textbox, ::String) #4417
Open
+18
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a return value of
nothing
is clearly wrong for this do-block as the lifted observable is a Tuple of Points.i came across this error when manually setting
displayed_string
in an app of mine.happy to add a test if someone suggests how to do so.EDIT: a 2nd commit now adds an unexported
unsafe_set!
, which like the extantset!
method sets thedisplayed_string
but does not throw an exception if the string does not pass the validator function. the use case is to highlight the portion of the string that does not pass the validator by replacing it with the invalid portion. was the most simple UI for an app of mine.Type of change
Delete options that do not apply:
Checklist