Split marker_offset from quad_offset

[ffreyer]

Description

For text we have:

• a position that acts as an anchor for the displayed string
• a char_offset which gives the position of each character relative to the string anchor point
• a quad_offset which gives places the rectangle containing the char relative to the character position

The user offset is included in char_offset. Both act in markerspace, though quad_offset also includes billboarding.

This pr effective translates this behavior to scatter. It now always centers, i.e. does the equivalent to character layouting under the hood, and considers marker_offset a pure user attribute. This removes the need for

Makie.jl/src/interfaces.jl

Lines 66 to 71 in 66c32da

	replace_automatic!(plot, :marker_offset) do
	# default to middle
	return lift(plot, plot[:markersize]) do msize
	return to_2d_scale(map(x -> x .* -0.5f0, msize))
	end
	end

in calculated_attributes, and it also fixes some niche errors:

• Bezierpath markers ignoring marker_offset (GLMakie, WGLMakie, CairoMakie)
• Char markers being complicated to center (GLMakie, WGLMakie) (using 0.5markersize doesn't quite work here)
• FastPixel ignoring marker_offset (GLMakie)
• marker_offset not working without billboarding in 3D (GLMakie, WGLMakie)
• Image markers translating in the wrong direction (CairoMakie)
• rotation acting on the position rather than marker for Rect (and FastPixel) markers (CairoMakie)

Changes:

• marker_offset is now independent of rotation. (So rotation = pi/2 doesn't turn (x, 0) into a translation in y direction) (GLMakie, WGLMakie)

Fixes #4383

Refimg before & after

2D no rotation

FastPixel is expected to be square in GLMakie, falls back onto Rect for other backends

	GLMakie	WGLMakie	CairoMakie
before
after

2D with billboarded rotation

Skipped FastPixel as it doesn't support rotation

	GLMakie	WGLMakie	CairoMakie
before
after

3D with Quaternion rotation

Everything is wrong in CairoMakie here, especially with space = :data. I assume fixing this requires reworking the scatter code at a larger scale, so I didn't bother with it here. Some placements improved regardless though.

	GLMakie	WGLMakie	CairoMakie
before
after

Attribute Example

Type of change

Could be considered breaking as marker_offset = Vec2f(0, 0) is now a centered marker instead of a bottom-left aligned marker. But with BezierPath, i.e. default markers not working with marker_offset we could also consider marker_offset to not really be supported right now.

• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• Added an entry in CHANGELOG.md (for new features and breaking changes)
• Updated docstring
• Added or changed relevant sections in the documentation
• Added reference image tests for new plotting functions, recipes, visual options, etc.

[MakieBot]

Benchmark Results

SHA: 272a41db69c1d331cb0f8a7982e5842310a0b700

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

[jkrumbiegel]

I'd consider this a bug fix

[ffreyer]

This is ready for review