Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indirect gem overrides #41

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 23, 2019

If a gem isn't directly referenced in the core-repo's gemfile it cannot
be overridden, ensure_gem has to be used.

Fixes #36

If a gem isn't directly referenced in the core-repo's gemfile it cannot
be overridden, ensure_gem has to be used.

Fixes ManageIQ#36
@agrare agrare requested a review from Fryguy October 23, 2019 00:27
@Fryguy Fryguy merged commit 69a18eb into ManageIQ:master Oct 23, 2019
@agrare agrare deleted the switch_to_ensure_gem branch October 23, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You can't currently specify GEM_REPOS if the TEST_REPO doesn't already define the gem as a direct dependency.
2 participants