Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --debug flag #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

NickLaMuro
Copy link
Member

Was going to use this to "--debug" some issues wih the ManageIQ/manageiq Rails 6.0 effort (specifically some failing builds due in manageiq-ui-classic), but turns out I was able figure it out without this change.

Regardless, I could see this being useful for others, so here is a PR.

🍅 🍅 🍅

Expands the existing `ENV` style debugging to allow it to be passed in
via a command line flag.

Makes the process of debugging more universal and provides a shared
mechanism for determining if debugging output should be enabled.
@agrare agrare requested review from agrare and Fryguy and removed request for agrare November 19, 2020 18:57
@gtanzillo gtanzillo added developer enhancement New feature or request labels Jan 14, 2021
@kbrock
Copy link
Member

kbrock commented Feb 8, 2022

@Fryguy do you want this? I could rebase if you do

@Fryguy
Copy link
Member

Fryguy commented Feb 9, 2022

Up to @agrare but let's get through the github actions first

@agrare
Copy link
Member

agrare commented Feb 22, 2022

We print out overrides already: https://github.com/ManageIQ/manageiq-cross_repo-tests/runs/5289161095?check_suite_focus=true#step:6:71 so not sure how much extra this adds?

@NickLaMuro
Copy link
Member Author

Got pinged on this, so figured I would chime in, but have no hard feelings for what decision is made:

(also, hey everyone! 👋 )

Regarding the puts "Contents of #{override_path}" part of this change, I find that to be the least useful part of the change, as it was just something that worked for me. I believe (memory failing me) it was mostly a double check that what was being generated by cross repo was what I expected, but I agree with @agrare that it probably already exists to some extent via bundler-inject.

I think the real value of the --debug flag is that it is available to the end user when doing --help, instead of having to know the ENV var exists by looking at the codebase (currently not in the README.md either)

Anyway, my </2cents>. ✌️

@agrare
Copy link
Member

agrare commented Feb 22, 2022

👋 hey @NickLaMuro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants