Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for supporting ppc64le #19689

Closed
wants to merge 12 commits into from
Closed

Changes for supporting ppc64le #19689

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9aad0f2
Changes for adding ppc64le support: correct version of postgresql is …
seth-priya Dec 26, 2019
557d8d0
Update .travis.yml
seth-priya Jan 1, 2020
23c4847
Merge branch 'master' of https://github.com/ManageIQ/manageiq
seth-priya Jan 7, 2020
7fc39fe
address review comments
seth-priya Jan 17, 2020
482e04a
Address review comments
seth-priya Feb 6, 2020
a99daba
Merge branch 'master' of https://github.com/ManageIQ/manageiq
seth-priya Feb 6, 2020
cdb3bd4
Merge branch 'master' of https://github.com/ManageIQ/manageiq
seth-priya Mar 17, 2020
587b7bc
Merge branch 'master' of https://github.com/ManageIQ/manageiq
seth-priya Mar 27, 2020
b6fc82c
Indentation correction
seth-priya Mar 27, 2020
ab7369e
Sync with ManageIQ/manageiq->master
svghadi Apr 28, 2020
e9e4877
Add cxxflags for unf_ext gem installation on power
svghadi Apr 28, 2020
374fedf
Merge pull request #1 from Siddhesh-Ghadi/master
seth-priya Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
dist: xenial
dist: bionic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we're updating the distribution because xenial doesn't support ppc64le?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xenial supports ppc64le but has the older (9.x) version of PostgreSQL, where we need 10.x

arch:
- amd64
- ppc64le
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change that we should make in all the repos before merging this in here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carbonin thank you and acknowledged, I have had to touch mostly the container-ruby and manageiq-pods repo only besides this, would you be able to point to the other repositories that need to have Travis support enabled or I guess I can look up each one under the ManageIQ umbrella? also as mentioned I am working directly with the Travis team to get the PostgreSQL sorted out on Power, so we post an update here once that is done and I can get the job to pass.

language: ruby
rvm:
- 2.5.7
Expand All @@ -17,8 +20,8 @@ env:
- TEST_SUITE=brakeman
matrix:
fast_finish: true
addons:
postgresql: '10'
services:
- postgresql
before_install:
- source ${TRAVIS_BUILD_DIR}/tools/ci/before_install.sh
before_script:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ ENV DATABASE_URL=postgresql://root@localhost/vmdb_production?encoding=utf8&pool=

RUN yum -y install --setopt=tsflags=nodocs \
memcached \
postgresql-server \
seth-priya marked this conversation as resolved.
Show resolved Hide resolved
postgresql-server \
seth-priya marked this conversation as resolved.
Show resolved Hide resolved
mod_ssl \
openssh-clients \
openssh-server \
Expand Down
1 change: 1 addition & 0 deletions tools/ci/setup_ruby_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
./tools/ci/setup_ruby_environment.rb
bundle config --local build.sassc --disable-march-tune-native
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going on here? Why is this needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is more context around why this was needed here #19520
Essentially the build fails while installing (or building) this gem if the --disable-march-tune-native flag is not set for ppc64le

export BUNDLE_WITHOUT=development
export BUNDLE_GEMFILE=${PWD}/Gemfile