Drop close issue #655
Merged
Drop close issue #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Nov 13, 2023
app/workers/stale_issue_marker.rb
Outdated
| end | ||
|
|
||
| def handle_newly_stale_issues | ||
| query = "is:open archived:false updated:<#{stale_date.strftime('%Y-%m-%d')}" | ||
| query = "is:open archived:false -label:stale updated:<#{stale_date.strftime('%Y-%m-%d')}" |
There was a problem hiding this comment.
I think if we remove the -label:stale, then this will just comment every 3 months, which is probably what we want.
|
update:
update:
|
We still want to mark issues as stale. And we want to do it every 3 months But we no longer want to close them after an additional 3 months. Instead, we will comment over and over
|
Checked commit kbrock@ab139b3 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets drop the auto close feature for stale PRs
I was not able to run tests locally, so this is more of a conversation starter.