Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.7.3-1 #1362

Open
wants to merge 2 commits into
base: manta
Choose a base branch
from
Open

Release v4.7.3-1 #1362

wants to merge 2 commits into from

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Feb 14, 2025

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping Dengjianping added L-release Related to a release A-calamari Area: Issues and PRs related to the Calamari Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up A-benchmark-checks A-integration-test-checks A-unit-test-checks labels Feb 14, 2025
@Dengjianping Dengjianping marked this pull request as ready for review February 14, 2025 06:41
@Dengjianping Dengjianping added the L-fixed Log: Issues and PRs related to bug fixes label Feb 14, 2025
@Dengjianping Dengjianping requested a review from ace155 February 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-unit-test-checks C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-fixed Log: Issues and PRs related to bug fixes L-release Related to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants